Closed
Bug 1144643
Opened 9 years ago
Closed 9 years ago
Gtk3 - support transparent and shaped widgets
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
Details
Attachments
(1 file)
923 bytes,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
Some elements in Gtk3 are supposed to be transparent or shaped. For instance overlay scrollbars and shaped tooltips.
Assignee | ||
Comment 1•9 years ago
|
||
Karl, what's the correct way to draw the semi-transparent and shaped widgets? Tweak nsNativeThemeGTK::GetWidgetTransparency() does not works, if it returns eTransparent the widgets still have some background...
Flags: needinfo?(karlt)
Assignee | ||
Comment 2•9 years ago
|
||
Please ignore that, sNativeThemeGTK::GetWidgetTransparency() works as expected.
Flags: needinfo?(karlt)
Assignee | ||
Comment 3•9 years ago
|
||
Uses transparent tooltips on Gtk3.
Attachment #8579353 -
Flags: review?(karlt)
Updated•9 years ago
|
Attachment #8579353 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f23a92135700
Comment 6•9 years ago
|
||
Same as the other bug. Why did your Try runs include tooltool manifest changes?
Keywords: checkin-needed
Comment 7•9 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #6) > Same as the other bug. Why did your Try runs include tooltool manifest > changes? This patch changes behaviour for only GTK3 builds, which are not in C-I. GTK3 builds do run on elm periodically (or at least did run - I haven't checked), but with many test failures. The tooltool changes from bug 1016641 provide an environment for a GTK3 build and so can be used to check that the build at least does not break. Martin, if non-GTK2 parts of code are changed, it's probably usually helpful to also do a standard (GTK2) try build. However, given the small change here, It's probably not worth it.
Keywords: checkin-needed
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/abf589d7f98d
Assignee: nobody → stransky
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/abf589d7f98d
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•