1144643 - Gtk3 - support transparent and shaped widgets

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Some elements in Gtk3 are supposed to be transparent or shaped. For instance overlay scrollbars and shaped tooltips.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Karl, what's the correct way to draw the semi-transparent and shaped widgets? Tweak nsNativeThemeGTK::GetWidgetTransparency() does not works, if it returns eTransparent the widgets still have some background...

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Please ignore that, sNativeThemeGTK::GetWidgetTransparency() works as expected.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch

Uses transparent tooltips on Gtk3.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f23a92135700

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Builds look okay.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Same as the other bug. Why did your Try runs include tooltool manifest changes?

Comment 7

[Karl Tomlinson (:karlt)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #6)
> Same as the other bug. Why did your Try runs include tooltool manifest
> changes?

This patch changes behaviour for only GTK3 builds, which are not in C-I.
GTK3 builds do run on elm periodically (or at least did run - I haven't checked), but with many test failures.  The tooltool changes from bug 1016641 provide an environment for a GTK3 build and so can be used to check that the build at least does not break.

Martin, if non-GTK2 parts of code are changed, it's probably usually helpful to also do a standard (GTK2) try build.  However, given the small change here, It's probably not worth it.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/abf589d7f98d

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/abf589d7f98d